-
Notifications
You must be signed in to change notification settings - Fork 383
docs: number-offset is HTML only option #7703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: number-offset is HTML only option #7703
Conversation
@mcanouil I believe we are supposed to handle quarto-cli/src/command/render/crossref.ts Line 37 in 8da91de
quarto-cli/src/resources/filters/crossref/index.lua Lines 175 to 187 in 8da91de
This could be look for commit history to understand the background. That would be worth looking why this is does not work anymore as it should have been. It seems deeper than just a documentation change. Or maybe it has never worked... 🤷♂️ Would be worth looking in the history We do have a Lua filter for this numbering feature in R Markdown (https://github.com/rstudio/rmarkdown/blob/main/inst/rmarkdown/lua/number-sections.lua) so I would assume this would have been ported over Anyhow, worth looking deeper (Did not do it, just sharing this info for now) |
Thanks @cderv I tried few versions of Quarto and if it ever worked it was a long time ago^^ |
Ok thanks for trying. Then the question should be raised in the team discussion for historical behavior. It may has been lost over version because not well tracked, and indeed not Pandoc supported. This would have been an addition from Quarto. For 1.4 this indeed seems to be a documentation update we need to confirm, and probably worth reinserting the feature properly (or debug) for later. (not sure about the timing). |
@dragonstyle added the 1.5 milestone to the original issue, thus this PR might only be for 1.4 time being (and possibly at most). Quick note: the few lines from Lua filter here seems to be for PDF books not simple PDF. |
(I'm still chasing old notifications, sorry for the delayed response) I'll wait to review when this passes tests. |
I fixed the typo... (early days on the codebase^^) |
I tried to merge against main and rebuild the build-js resources but I don't know where my push ended up 🤷. @mcanouil Can you merge against main, run |
This looks good, thanks. I don't think we need a changelog entry. |
This PR updates the reference options for.
number-offset
which is an HTML only option.Related to #6842.
Until Pandoc uses the option on other formats, it is better to not wrongly display it in all formats.